Skip to content

Fix printing over 2nd cell in wide character should delete wide character #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix printing over 2nd cell in wide character should delete wide character #1275

merged 2 commits into from
Oct 16, 2023

Conversation

christianparpart
Copy link
Member

@christianparpart christianparpart commented Oct 15, 2023 •
edited
Loading

closes #1268

i mean, this is currently only the test case added. fix comming next.

  • test case added
  • fix implemented
  • changelog updated

@github-actions github-actions bot added VT: Backend Virtual Terminal Backend (libterminal API) test Unit tests labels Oct 15, 2023
@christianparpart
[vtbackend] SimpleCell: Removes superfluous CellFlags
a11e2a6 
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart marked this pull request as ready for review October 16, 2023 07:09
@christianparpart christianparpart force-pushed the fix/DCH-wides branch 2 times, most recently from 39d25cd to aee0f34 Compare October 16, 2023 07:54
@christianparpart
[vtbackend] Screen: Fix printing over right cell of a wide character …
00b8ce3 
…should delete wide character

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart merged commit 5b752b8 into master Oct 16, 2023
@christianparpart christianparpart deleted the fix/DCH-wides branch October 16, 2023 10:29
@christianparpart christianparpart mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Printing over 2nd cell in wide character should delete wide character
1 participant
@christianparpart