Skip to content

Refactor keyboard input handling #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

Refactor keyboard input handling #1250

merged 1 commit into from
Oct 12, 2023

Conversation

christianparpart
Copy link
Member

Modularize InputGenerator's keyboard input handling into its own special class.

This should ideally improve readability/maintainability of the (keyboard) input generating logic.

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Oct 10, 2023
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch 2 times, most recently from cdb6814 to e8d2d5e Compare October 11, 2023 14:05
@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Oct 11, 2023
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch from e8d2d5e to e50000c Compare October 11, 2023 15:16
@github-actions github-actions bot removed the frontend Contour Terminal Emulator (GUI frontend) label Oct 11, 2023
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch 4 times, most recently from 7e9d51b to 6ecfdef Compare October 11, 2023 23:05
@christianparpart christianparpart mentioned this pull request Oct 12, 2023
Merged
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch from 6ecfdef to 2b34ab4 Compare October 12, 2023 08:08
@github-actions github-actions bot added frontend Contour Terminal Emulator (GUI frontend) test Unit tests labels Oct 12, 2023
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch 5 times, most recently from d583598 to 73c3953 Compare October 12, 2023 17:11
@github-actions github-actions bot removed the frontend Contour Terminal Emulator (GUI frontend) label Oct 12, 2023
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch 2 times, most recently from eca2858 to 77175f2 Compare October 12, 2023 19:33
@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Oct 12, 2023
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch 2 times, most recently from b1950ff to 09fa0cc Compare October 12, 2023 19:51
@christianparpart christianparpart marked this pull request as ready for review October 12, 2023 19:52
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch from 09fa0cc to 556cd96 Compare October 12, 2023 20:13
@christianparpart
[vtbackend] Modularize InputGenerator's keyboard input handling into …
15b3879 
…its own special class.

This is mostly in preparation for future alternate keyboard protocols.
But the modularization should also help making the code more reviewable.

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart force-pushed the improvement/keyboard-input branch from 556cd96 to 15b3879 Compare October 12, 2023 20:58
@christianparpart christianparpart merged commit 6475797 into master Oct 12, 2023
@christianparpart christianparpart deleted the improvement/keyboard-input branch October 12, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
frontend Contour Terminal Emulator (GUI frontend) test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@christianparpart