Match speeds for DECSSCLS as defined by old DEC VT1xx and VT2xx terminals #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83fa56b to
d782937
Compare
j4james
reviewed
Oct 3, 2023
src/vtbackend/Screen.cpp
Outdated
Comment on lines
851
to
857
| 1, // 0 | ||
| 2, // 1 | ||
| 3, // 0 | ||
| 6, // 1 | ||
| 9, // 2 | defined by spec to be 18 lines per second | ||
| 13, // 3 | ||
| 12, // 3 | ||
| 18, // 4 | defined by spec to be 18 lines per second |
There was a problem hiding this comment.
That's exactly what I meant. Thank you.
However, I just noticed the comment for 2 is wrong. You've got both the 2 and 4 comments saying "defined by spec to be 18 lines per second". The first one should assumedly be "9 lines per second".
There was a problem hiding this comment.
Ooops, copy'n'paste bug. thx ;)
…T1xx and VT2xx terminals Signed-off-by: Christian Parpart <christian@parpart.family>
d782937 to
56607dd
Compare
j4james
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References @j4james comment in https://github.com/contour-terminal/contour/pull/1212/files#r1344674416
I hope I did understand you correctly there?