Skip to content

Avoid rendering empty space when cutting off overly wide LCD subpixel AA glyphs #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2023
Merged

Avoid rendering empty space when cutting off overly wide LCD subpixel AA glyphs #1213

merged 3 commits into from
Sep 29, 2023

Conversation

Yaraslaut
Copy link
Member

Closes #1022
Issue is that we were calling restrict
void TextRenderer::restrictToTileSize(TextureAtlas::TileCreateData& tileCreateData)
it can happen that tile is only partially larger and then we end up in such situation :

[2023-09-23 07:17:58.886218542.886218] [vt.rasterizer] Inserting rasterized_glyph(0, 12x13+(-1, 13), rgb) (bbox 10x17, numCells 1) id 7034 render mode LCD Text yOverflow 0 yMin 4.
[2023-09-23 07:17:58.886221347.886221] [vt.rasterizer] Cutting off oversized RGB tile from 12x13 down to 10x21.

This cutting was copying empty rows

@github-actions github-actions bot added the VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library label Sep 23, 2023
@Yaraslaut @christianparpart
[text_shaper] open_shaper: minor debug print improvement
5098f4d 
Signed-off-by: Christian Parpart <christian@parpart.family>
@github-actions github-actions bot added the fonts font rasterization and text shaping API and platform implementations label Sep 29, 2023
@christianparpart christianparpart changed the title Restrict tile only if we have larger tile Avoid rendering empty space when cutting off overly wide LCD subpixel AA glyphs Sep 29, 2023
@Yaraslaut
Copy link
Member Author

Yaraslaut commented Sep 29, 2023 •
edited
Loading

While rendering is much better now, tile is not center properly
image

@christianparpart christianparpart force-pushed the fix/texture_overlap branch 2 times, most recently from 66aadea to 79ad6e8 Compare September 29, 2023 13:48
@christianparpart
[vtrasterizer] Overall code readability improvements
ae2a85d 
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart
[vtrasterizer] TextRenderer: Adjust the normalized width and height t…
51b9907 
…o not render the empty space

Signed-off-by: Christian Parpart <christian@parpart.family>
@Yaraslaut
Copy link
Member Author

Now everything works fine :)

@christianparpart christianparpart merged commit b81740b into master Sep 29, 2023
@christianparpart christianparpart deleted the fix/texture_overlap branch September 29, 2023 17:35
@Yaraslaut Yaraslaut mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart left review comments

Assignees
No one assigned
Labels
fonts font rasterization and text shaping API and platform implementations VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Texture atlas overlap in glyphs when rendering, result in ghost-boxed characters
2 participants
@Yaraslaut @christianparpart