Skip to content

Fixes DECSTBM and DECSLRM reset #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fixes DECSTBM and DECSLRM reset #1165

merged 1 commit into from
Aug 30, 2023

Conversation

Utkarsh-khambra
Copy link
Collaborator

Closes #1164

@github-actions github-actions bot added VT: Backend Virtual Terminal Backend (libterminal API) test Unit tests labels Aug 14, 2023
@Utkarsh-khambra Utkarsh-khambra changed the title Fixes DECSTBM reset`` Fixes DECSTBM reset Aug 14, 2023
@Utkarsh-khambra Utkarsh-khambra changed the title Fixes DECSTBM reset Fixes DECSTBM and DECSLRM reset Aug 14, 2023
@Utkarsh-khambra Utkarsh-khambra force-pushed the bugfix/1164 branch 2 times, most recently from 0a09058 to 4e07a87 Compare August 14, 2023 10:00
christianparpart
christianparpart reviewed Aug 14, 2023
View reviewed changes
@Utkarsh-khambra Utkarsh-khambra marked this pull request as draft August 15, 2023 13:37
@Utkarsh-khambra Utkarsh-khambra marked this pull request as ready for review August 29, 2023 14:19
christianparpart
christianparpart approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, @Utkarsh-khambra :-)

@christianparpart christianparpart merged commit a09d74b into master Aug 30, 2023
@christianparpart christianparpart deleted the bugfix/1164 branch August 30, 2023 14:30
@christianparpart christianparpart mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DECSTBM and DECSLRM doesn't work when used to reset margins.
2 participants
@Utkarsh-khambra @christianparpart