Skip to content

Makes the bell silent #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2023
Merged

Makes the bell silent #1159

merged 2 commits into from
Aug 18, 2023

Conversation

Utkarsh-khambra
Copy link
Collaborator

@Utkarsh-khambra Utkarsh-khambra commented Aug 10, 2023 •
edited
Loading

Adds a config option bell under profile to configure BEL behaviour and Fixes #1162 , #1163

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Aug 10, 2023
@Utkarsh-khambra Utkarsh-khambra requested review from Yaraslaut and christianparpart and removed request for christianparpart August 10, 2023 15:36
Utkarsh-khambra
Utkarsh-khambra commented Aug 10, 2023
View reviewed changes
Yaraslaut
Yaraslaut requested changes Aug 10, 2023
View reviewed changes
@Yaraslaut
Copy link
Member

Yaraslaut commented Aug 10, 2023 •
edited
Loading

Also, we need to update documentation here index.md

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 10, 2023
@Utkarsh-khambra Utkarsh-khambra force-pushed the feature/silence-bell branch 2 times, most recently from 9c236f4 to c8fecb5 Compare August 10, 2023 17:57
christianparpart
christianparpart requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only very minors, that might make sense to apply. What do you think?

@Utkarsh-khambra
Copy link
Collaborator Author

Utkarsh-khambra commented Aug 11, 2023 •
edited
Loading

I read the suggestion about making bell to be off , default or path to make more configurable. Working on that.

@christianparpart christianparpart marked this pull request as draft August 11, 2023 20:59
@Utkarsh-khambra Utkarsh-khambra force-pushed the feature/silence-bell branch 3 times, most recently from dc4d528 to 74aa421 Compare August 12, 2023 18:18
@Utkarsh-khambra Utkarsh-khambra marked this pull request as ready for review August 12, 2023 18:18
@Utkarsh-khambra Utkarsh-khambra force-pushed the feature/silence-bell branch 3 times, most recently from a903897 to 12dd60b Compare August 13, 2023 07:06
@Utkarsh-khambra Utkarsh-khambra force-pushed the feature/silence-bell branch 3 times, most recently from 2c54f11 to 18ad2e0 Compare August 13, 2023 17:08
Yaraslaut
Yaraslaut requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like not all wav files are good for a bell sound, i just downloaded random one from https://mixkit.co/free-sound-effects/bell/ and it didn't work :(

@Utkarsh-khambra
Copy link
Collaborator Author

Utkarsh-khambra commented Aug 14, 2023 •
edited
Loading

@Yaraslaut can you link a specific one? I tried a bunch of 'em from here already and they worked.

christianparpart
christianparpart reviewed Aug 14, 2023
View reviewed changes
christianparpart
christianparpart reviewed Aug 14, 2023
View reviewed changes
christianparpart
christianparpart reviewed Aug 14, 2023
View reviewed changes
christianparpart
christianparpart reviewed Aug 14, 2023
View reviewed changes
christianparpart
christianparpart requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have used the review functionality from the start. :)

@Utkarsh-khambra Utkarsh-khambra force-pushed the feature/silence-bell branch 2 times, most recently from 4215bb4 to 57b21e7 Compare August 16, 2023 16:37
christianparpart
christianparpart approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks

@christianparpart christianparpart merged commit cd8d2c0 into master Aug 18, 2023
@christianparpart christianparpart deleted the feature/silence-bell branch August 18, 2023 13:15
@Ne02ptzero Ne02ptzero mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaraslaut Yaraslaut Yaraslaut requested changes

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeatedly outputting BEL doesn't produce any sound
3 participants
@Utkarsh-khambra @Yaraslaut @christianparpart