Skip to content

Fix glyphs overlap by creating spacing between tiles in Atlas #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix glyphs overlap by creating spacing between tiles in Atlas #1139

merged 1 commit into from
Jul 20, 2023

Conversation

Yaraslaut
Copy link
Member

Closes #1022

@github-actions github-actions bot added the VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library label Jul 19, 2023
@Yaraslaut Yaraslaut requested a review from whisperity July 19, 2023 12:20
christianparpart
christianparpart approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. it took a while for my brain, hands, and eyes - sorry. :)

@Yaraslaut Yaraslaut enabled auto-merge July 20, 2023 18:06
@Yaraslaut Yaraslaut merged commit c20847b into master Jul 20, 2023
@Yaraslaut Yaraslaut deleted the fix/1022 branch July 20, 2023 18:28
@Yaraslaut Yaraslaut mentioned this pull request Jul 21, 2023
Closed
This was referenced Jul 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

@whisperity whisperity Awaiting requested review from whisperity

Assignees
No one assigned
Labels
VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Texture atlas overlap in glyphs when rendering, result in ghost-boxed characters
2 participants
@Yaraslaut @christianparpart