-
-
Notifications
You must be signed in to change notification settings - Fork 131
show terminal dimension on resize #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very nice. Many thanks, I will look into it as soon as tomorrow morning :-) |
I changed description a bit to make github realise that this PR connected to Issue, since when links inside " |
Yes sure, I'll do it. How we proceed with this feature then? |
Hey @elmarsan. I am pretty certain we can merge #761 in the current week. You could already have a look at it.
It is actually safe to try it out already, There are no code changes expected in this PR, only the minimum amount to get all CI green. So if you're curious, give it a try, and if you need help with anything or git force-push related actions, join us at Discord. |
p.s.: I was apparently and obviously wrong about the "no code changes" argument. We're trying hard to clean things up before the merge. The only thing in #761 left out seems to be IME. We might merge the PR before having IME sorted out and work on IME on its own PR, so you can also start reworking your contribution (at least having the chance to). I am certain we can still hold the timeframe as mentioned early (getting #761 merged by this week). Many thanks for your patience, @elmarsan. |
Hey @christianparpart thanks a lot for the update! |
Hi, we merget qml pr (#761) into master |
@Yaraslaut Thanks. I'll update this pr ASAP. |
@elmarsan you can also join us on Discord. Feel free to ask questions there or here. Take your time. :) |
Description
Motivation and Context
Fix issue: https://github.com/contour-terminal/contour/issues/975
#975
How Has This Been Tested?
Tested manually due the feature pertains to ui scope.
contour-resize.webm