Skip to content

Conversation

elmarsan
Copy link
Contributor

@elmarsan elmarsan commented Jul 9, 2023

Description

Display little dialog with terminal dimension on resize window.

Motivation and Context

Fix issue: https://github.com/contour-terminal/contour/issues/975

#975

How Has This Been Tested?

Tested manually due the feature pertains to ui scope.

contour-resize.webm

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Jul 9, 2023
@christianparpart christianparpart disabled auto-merge July 9, 2023 20:44
@christianparpart
Copy link
Member

Very nice. Many thanks, I will look into it as soon as tomorrow morning :-)

@Yaraslaut
Copy link
Member

I changed description a bit to make github realise that this PR connected to Issue, since when links inside " " they are not parsed

@Yaraslaut
Copy link
Member

Thanks a lot @elmarsan for contribution, we are planning to merge #761 soon, maybe you a willing to update this implementation to QML then ? :) sorry for inconvinience that we are changing frontend.
Also, we have a Discord, just in case you want to join.

@elmarsan
Copy link
Contributor Author

Thanks a lot @elmarsan for contribution, we are planning to merge #761 soon, maybe you a willing to update this implementation to QML then ? :) sorry for inconvinience that we are changing frontend. Also, we have a Discord, just in case you want to join.

Yes sure, I'll do it. How we proceed with this feature then?
Shall we wait until frontend migration is done?

@christianparpart
Copy link
Member

Hey @elmarsan.
Many thanks for your contribution!

I am pretty certain we can merge #761 in the current week.

You could already have a look at it.
A few things will happen on #761 until merge:

  • expect force pushes (sorry), to get the history cleaned up
  • we're most likely squashing that huge PR into a single a very few commits right before merge

It is actually safe to try it out already, There are no code changes expected in this PR, only the minimum amount to get all CI green.

So if you're curious, give it a try, and if you need help with anything or git force-push related actions, join us at Discord.

@christianparpart
Copy link
Member

p.s.: I was apparently and obviously wrong about the "no code changes" argument. We're trying hard to clean things up before the merge. The only thing in #761 left out seems to be IME. We might merge the PR before having IME sorted out and work on IME on its own PR, so you can also start reworking your contribution (at least having the chance to). I am certain we can still hold the timeframe as mentioned early (getting #761 merged by this week).

Many thanks for your patience, @elmarsan.

@elmarsan
Copy link
Contributor Author

Hey @christianparpart thanks a lot for the update!
Not worries. I've being checking #761 and seems quite big. However this feature does not involves lots of changes, so probably will be easy to rework on it after the merge.

@Yaraslaut
Copy link
Member

Hey @christianparpart thanks a lot for the update! Not worries. I've being checking #761 and seems quite big. However this feature does not involves lots of changes, so probably will be easy to rework on it after the merge.

Hi, we merget qml pr (#761) into master

@elmarsan
Copy link
Contributor Author

@Yaraslaut Thanks. I'll update this pr ASAP.

@christianparpart
Copy link
Member

@elmarsan you can also join us on Discord. Feel free to ask questions there or here. Take your time. :)

@christianparpart
Copy link
Member

I'm closing this in favor of the final solution in #1203. Many many thanks, @elmarsan for actually pushing and contributing anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants