Invert direction for downwards glyphs #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. Many thanks. Do we know how that should look like ideally? So we have something to work towards? |
christianparpart
requested changes
Jun 7, 2023
Co-authored-by: Christian Parpart <christian@parpart.family>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1115
See https://freetype.org/freetype2/docs/reference/ft2-base_interface.html#ft_glyphslotrec
bitmap_topcan be negative, meaning that glyph direction is downward, this PR fixes the crash when contour can not display such glyphs, this is itself a hack since this is not how properly handle this case i suppose.For example such figures still can be generated in contour