Skip to content

fix: take into account the status line height when rendering sixels. #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2023
Merged

fix: take into account the status line height when rendering sixels. #1051

merged 3 commits into from
Feb 26, 2023

Conversation

Utkarsh-khambra
Copy link
Collaborator

@Utkarsh-khambra Utkarsh-khambra commented Feb 25, 2023 •
edited
Loading

When sixel image is being rendered, if status line is visible then total renderable area should not cover the statusline area.
Fixes #1050

@github-actions github-actions bot added test Unit tests VT: Backend Virtual Terminal Backend (libterminal API) labels Feb 25, 2023
@Utkarsh-khambra Utkarsh-khambra changed the title fix: take into account the status line height. fix: take into account the status line height when rendering sixels. Feb 25, 2023
christianparpart
christianparpart requested changes Feb 25, 2023
View reviewed changes
@github-actions github-actions bot added the VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library label Feb 25, 2023
@Utkarsh-khambra Utkarsh-khambra force-pushed the fix/1050 branch 2 times, most recently from 3850a52 to ee1d684 Compare February 25, 2023 12:37
christianparpart
christianparpart reviewed Feb 25, 2023
View reviewed changes
@Yaraslaut Yaraslaut enabled auto-merge February 26, 2023 06:08
@Yaraslaut Yaraslaut merged commit b81331e into master Feb 26, 2023
@Yaraslaut Yaraslaut deleted the fix/1050 branch February 26, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
test Unit tests VT: Backend Virtual Terminal Backend (libterminal API) VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sixel graphics not rendered while intersects with status line
3 participants
@Utkarsh-khambra @christianparpart @Yaraslaut