simplify, cleanup, and improve window size/resize handling #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d44e425 to
e3ab76a
Compare
7d1dfed to
b7a2533
Compare
b7a2533 to
3f92dc8
Compare
3f92dc8 to
ad37e44
Compare
ad37e44 to
6578e5f
Compare
Signed-off-by: Christian Parpart <christian@parpart.family>
…atusLine(str) has an active lifetime The only caller here returns a temporary std::string via f(g()). Since the target storage is also already an std::string, we might as well just std::move it into it. Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
…ensive Signed-off-by: Christian Parpart <christian@parpart.family>
a5888ec to
ad84c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it took me a while to figure out that fraction scaling on KDE Plasma (probably due to Wayland) is problematic. However, this PR still cleans up a lot and reliably produces the expected columns x lines page size on initial window spawn.
Fractional scaling on at least Wayland (KDE?) should be fixed later on its own.