Skip to content

Fix crush when status line is enabled #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

Fix crush when status line is enabled #1497

merged 2 commits into from
Jun 20, 2024

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Apr 16, 2024 •
edited
Loading

This PR fixed a crush that i notice often when using status line
Closes #1511

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Apr 16, 2024
@Yaraslaut Yaraslaut added the no changelog Tells the CI to not require a changelog entry label Apr 16, 2024
christianparpart
christianparpart reviewed Apr 16, 2024
View reviewed changes
@Yaraslaut Yaraslaut force-pushed the fix/status_line_bug branch from 6d8408b to 29551f7 Compare April 29, 2024 04:32
@Yaraslaut Yaraslaut force-pushed the fix/status_line_bug branch from 29551f7 to 50cdb1f Compare May 26, 2024 04:23
@Yaraslaut Yaraslaut mentioned this pull request May 27, 2024
Closed
@Yaraslaut Yaraslaut force-pushed the fix/status_line_bug branch 3 times, most recently from 9631f5d to 94729b5 Compare May 29, 2024 15:07
@Yaraslaut Yaraslaut force-pushed the fix/status_line_bug branch from 94729b5 to 6e51ef5 Compare June 18, 2024 06:36
@github-actions github-actions bot added the CI GitHub Actions & CI label Jun 19, 2024
@github-actions github-actions bot removed the CI GitHub Actions & CI label Jun 19, 2024
Yaraslaut and others added 2 commits June 20, 2024 11:31
@Yaraslaut @christianparpart
Fix crash when status line is enabled
b278c92
@christianparpart
[vtbackend] Refactor Sequencer into SequenceBuilder to increase code …
93fec67 
…share.

Also, SequenceBuilder is the way better and more intuitive name than Sequencer :)

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart merged commit ae4ebc4 into master Jun 20, 2024
@christianparpart christianparpart deleted the fix/status_line_bug branch June 20, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart left review comments

Assignees
No one assigned
Labels
no changelog Tells the CI to not require a changelog entry VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion failed: (_buffer->begin() <= _region.data() && (_region.data() + _region.size()) <= _buffer->end()), function BufferFragment
2 participants
@Yaraslaut @christianparpart