feat: allow logging output to use JSON formatter #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GridexX <arsene582@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 68.30% 68.83% +0.53%
==========================================
Files 26 26
Lines 2407 2448 +41
==========================================
+ Hits 1644 1685 +41
Misses 664 664
Partials 99 99
☔ View full report in Codecov by Sentry. |
piksel
requested changes
Aug 12, 2023
|
Apparently, I never submitted the review earlier. Sorry for the take-over. Does my changes make sense? Again, sorry for the bad communication here. |
a8344e4 to
426f9ff
Compare
piksel
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Enable JSON Logging - PR for Issue #28
Description:
This PR addresses and resolves the long-standing issue #28 in the
containrrr/watchtowerrepository. The issue is related to enabling JSON logging for the application.Changes:
--json-loggingthat enables the JSON log formatter for logging.WATCHTOWER_JSON_LOGGINGto control JSON logging behavior.Context:
As this is my first-ever Pull Request, I'm excited to contribute to the
containrrr/watchtowerproject. I'm building a log scraping application and enabling JSON logging will greatly facilitate log parsing and analysis in my use case.Testing:
I have included comprehensive test coverage for the new argument in the
flags_test.gofile, ensuring proper functionality and compatibility with existing features.I would greatly appreciate feedback and guidance on any improvements that can be made to this PR. Looking forward to contributing more to the project in the future! Thank you for considering this pull request.