feat: add no-pull label for containers #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fb4e66 to
fb8dd3b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
==========================================
+ Coverage 66.77% 66.91% +0.13%
==========================================
Files 25 25
Lines 2366 2376 +10
==========================================
+ Hits 1580 1590 +10
Misses 685 685
Partials 101 101
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
piksel
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a "no-pull" label (
com.centurylinklabs.watchtower.no-pull) to enable the global--no-pullfunctionality on a per-container basis.It is based off @nedzadalibegovic's work in #1415, but tests and documentation were missing in their PR, so I added them. Note that I didn't add tests for
IsContainerStalefunction because this function is untested in the existing codebase, and it is tedious to test (which is probably the reason why it's untested yet).Fixes #1256
Closes #1415