feat(smtp): add support for custom client host #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also handle and log when the initial response from the server isn't valid, giving a better error message in these cases.
Codecov ReportBase: 77.96% // Head: 78.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 77.96% 78.49% +0.52%
==========================================
Files 96 96
Lines 2900 2934 +34
==========================================
+ Hits 2261 2303 +42
+ Misses 467 462 -5
+ Partials 172 169 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
clienthostproperty that can be used to send a specific host name during the initialHELO/EHLOgreeting phase. It can also be set toautoto use the OS hostname as the client host name.Solves connections to
smtp-relay.gmail.comwhich soft-requires the name to be non-generic:support.google.com/a/answer/2956491
This will also handle and log when the initial response from the server isn't valid, giving a better error message in these cases.
Fixes #270