Skip to content

cleanup(pushbullet): TLC #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2021
Merged

cleanup(pushbullet): TLC #180

merged 1 commit into from
Jul 4, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jul 4, 2021 •
edited
Loading

Giving a neglected service some ❤

  • Increase test coverage
  • Implement missing parts of the Push API
  • Actually handle errors (and return API errors to consumer)
  • Use common service helpers / JSON Client
  • Title is now actually settable the same way as all other service props

Ref #176

@piksel
cleanup(pushbullet): TLC
56c29cb 
- add more test coverage
- implement missing parts of the API
- handle errors
- use common service helpers
@codecov
Copy link

codecov bot commented Jul 4, 2021

Codecov Report

Merging #180 (56c29cb) into main (1e34cb3) will increase coverage by 1.61%.
The diff coverage is 70.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   61.96%   63.57%   +1.61%     
==========================================
  Files          84       84              
  Lines        2692     2693       +1     
==========================================
+ Hits         1668     1712      +44     
+ Misses        879      832      -47     
- Partials      145      149       +4
Impacted Files Coverage Δ
pkg/util/util.go 72.72% <0.00%> (-27.28%) ⬇️
pkg/util/jsonclient/jsonclient.go 70.45% <58.82%> (-9.55%) ⬇️
pkg/services/pushbullet/pushbullet.go 73.91% <68.75%> (+73.91%) ⬆️
pkg/services/pushbullet/pushbullet_config.go 77.77% <77.77%> (+23.23%) ⬆️
pkg/services/pushbullet/pushbullet_json.go 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e34cb3...56c29cb. Read the comment docs.

@piksel piksel merged commit dbe0e3b into main Jul 4, 2021
@piksel piksel deleted the feature/pushbullet-tlc branch July 4, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@piksel