Assert service compliance #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
485bc97 to
b8c4d0c
Compare
note: the title is ignored by default (titlevalue set to 0)
this also changes the behaviour of long messages, since the maximum length of the Message field for opsgenie is 140 characters. in both of these cases, the Description will be used for the full message, and the message will be set to the title (or to the first 130 characters of the message if no title is provided).
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 64.16% 63.96% -0.20%
==========================================
Files 70 70
Lines 2009 2026 +17
==========================================
+ Hits 1289 1296 +7
- Misses 606 611 +5
- Partials 114 119 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This intentionally includes tests that currently fail.Service Compliance information moved to wiki page.
The general point of this PR is to add tests to make sure that all services comply with the first Service Compliance rule:
Added test resulted in the following services that did not pass:
Telegram
Supports Params? ✔ Yes!
Supports Title prop? ⚫ No
Silently ignores title? ❌ Error:
title is not a valid config key [channels notification parsemode preview]IFTT
Supports Params? ✔ Yes!
Uses title prop? ⚫ No
Silently ignores title? ❌Error
"title is not a valid config key [events messagevalue value1 value2 value3]"OpsGenie
Supports Params? ✔ Yes!
Uses title prop? ⚫ No
Silently ignores title? ❌ Error:
title is not a valid config key [actions alias description details entity note priority responders source tags user visibleto]Fixes for the above services were added, and all three now pass. IFTT and OpsGenie can actually make use of the title as well if configured, but Telegram just ignores it.