Skip to content

fix idmapped mounts test failure on vfs #25687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2025
Merged

fix idmapped mounts test failure on vfs #25687

merged 2 commits into from
Mar 26, 2025

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Mar 26, 2025 •
edited
Loading

Does this PR introduce a user-facing change?

Closes: #25572

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2025
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@giuseppe giuseppe force-pushed the reenable-vfs-test branch from ee8a3cf to 28b7da6 Compare March 26, 2025 10:28
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2025
giuseppe added 2 commits March 26, 2025 12:11
@giuseppe
vendor: update c/{common,storage}
7f59274 
Closes: containers#25572

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
test: re-enable idmapped mounts test on vfs
1f3347f 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the reenable-vfs-test branch from 28b7da6 to 1f3347f Compare March 26, 2025 11:11
Luap99
Luap99 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Mar 26, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f5ab9d1 into containers:main Mar 26, 2025
89 checks passed
@Luap99 Luap99 mentioned this pull request Apr 1, 2025
Merged
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 25, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: podman run - idmapped mounts issue with vfs
4 participants
@giuseppe @mheon @Luap99 @openshift-merge-robot