Skip to content

[DO NOT MERGE] test https://github.com/containers/storage/pull/2285 #25606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE] test https://github.com/containers/storage/pull/2285 #25606

wants to merge 3 commits into from

Conversation

giuseppe
Copy link
Member

Followup for #25589

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Mar 17, 2025
@giuseppe giuseppe mentioned this pull request Mar 17, 2025
Closed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch from 7864b57 to f6cf06b Compare March 17, 2025 13:57
@giuseppe giuseppe closed this Mar 17, 2025
@giuseppe giuseppe mentioned this pull request Mar 17, 2025
Merged
@giuseppe giuseppe reopened this Mar 18, 2025
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch from f6cf06b to c1df8b5 Compare March 18, 2025 10:36
@giuseppe giuseppe closed this Mar 18, 2025
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch from c1df8b5 to e5b5e14 Compare March 18, 2025 12:43
@giuseppe giuseppe reopened this Mar 18, 2025
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch 8 times, most recently from e361a6d to 246a8d0 Compare March 19, 2025 14:19
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@giuseppe giuseppe added the bloat_approved Approve a PR in which binary file size grows by over 50k label Mar 19, 2025
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch 7 times, most recently from e7b8da9 to a53a40f Compare March 19, 2025 20:49
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch 2 times, most recently from fbb7c4b to 5dcca39 Compare March 20, 2025 07:42
@giuseppe giuseppe mentioned this pull request Mar 21, 2025
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2025
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch 2 times, most recently from 68974b3 to 1c969ee Compare March 24, 2025 21:06
@l0rd @giuseppe
Fix flake on machine cp e2e test
df182b7 
Explicitly close file to avoid machine e2e test
to fail on CI from time to time.

See for example this failed execution of the machine-wsl task:
https://api.cirrus-ci.com/v1/artifact/task/6697640798191616/html/machine-wsl-podman-windows-rootless-host-sqlite.log.html

Fix containers#25614

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch from 1c969ee to 3f0b7f8 Compare March 24, 2025 21:46
giuseppe added 2 commits March 24, 2025 23:05
@giuseppe
vendor: update c/storage and c/common
0580fea 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
test: re-enable test
4a1d9a1 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the test-storage-fix-vfs branch from 3f0b7f8 to 4a1d9a1 Compare March 24, 2025 22:05
@giuseppe giuseppe closed this Mar 26, 2025
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 25, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giuseppe @openshift-merge-robot @l0rd