-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Prepare tests for better reuse with zstd:chunked pulls #23379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"/my-alpine" is also being used by tests in search_test.go; use unique names to make sure we are trying to pull the encrypted images created in the test. Purely to avoid doubt, this should not actually change (test) behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Actually test decryption, instead of handling of TLS failures. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…ault It is not the default _yet_, but we are testing such setups. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Compare #23348 testing the future c/changes. |
LGTM |
@mheon @Luap99 @baude @ashley-cui @l0rd PTAL |
@edsantiago PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Does this PR introduce a user-facing change?