Skip to content

Prepare tests for better reuse with zstd:chunked pulls #23379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jul 23, 2024

Does this PR introduce a user-facing change?

None

mtrmac added 3 commits July 23, 2024 21:26
"/my-alpine" is also being used by tests in search_test.go;
use unique names to make sure we are trying to pull the encrypted
images created in the test.

Purely to avoid doubt, this should not actually change (test) behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Actually test decryption, instead of handling of TLS failures.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…ault

It is not the default _yet_, but we are testing such setups.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2024
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 23, 2024

Compare #23348 testing the future c/changes.

@rhatdan
Copy link
Member

rhatdan commented Jul 23, 2024

LGTM
@giuseppe PTAL

@rhatdan
Copy link
Member

rhatdan commented Jul 23, 2024

@mheon @Luap99 @baude @ashley-cui @l0rd PTAL

@mheon
Copy link
Member

mheon commented Jul 23, 2024

@edsantiago PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 85358ae into containers:main Jul 24, 2024
58 checks passed
@mtrmac mtrmac deleted the chunked-tests branch July 24, 2024 20:02
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 23, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants