Skip to content

Vendor c/common:8483ef6022b4 #23807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Vendor c/common:8483ef6022b4 #23807

merged 1 commit into from
Aug 30, 2024

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Aug 29, 2024

This PR vendor pre-release version of c/common:8483ef6022b4 fixes #23331. It also adapts the code to the new c/common/libimage API.

fixes: #23331

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 29, 2024
@Honny1 Honny1 marked this pull request as ready for review August 29, 2024 14:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2024
@Honny1 Honny1 force-pushed the fix-top-layer-not-found-storage branch from 550da62 to 4691838 Compare August 29, 2024 15:02
@Honny1 Honny1 added the No New Tests Allow PR to proceed without adding regression tests label Aug 29, 2024
@Honny1
Copy link
Member Author

Honny1 commented Aug 29, 2024

/packit retest-failed

@Luap99 Luap99 added the bloat_approved Approve a PR in which binary file size grows by over 50k label Aug 29, 2024
@Luap99
Copy link
Member

Luap99 commented Aug 29, 2024

Please add the PR description also in the commit message.

@Honny1
Copy link
Member Author

Honny1 commented Aug 29, 2024

Should I include the part about user-facing change?

@Honny1 Honny1 force-pushed the fix-top-layer-not-found-storage branch from 4691838 to 4e705e8 Compare August 29, 2024 15:46
@Luap99
Copy link
Member

Luap99 commented Aug 29, 2024

Should I include the part about user-facing change?

Not needed IMO, although you could add "fixed a race in image listing that printed spurious warnings" or something like this

@Honny1 Honny1 force-pushed the fix-top-layer-not-found-storage branch from 4e705e8 to d43831b Compare August 29, 2024 15:58
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@Luap99
Copy link
Member

Luap99 commented Aug 29, 2024

It looks like your change is breaking the podman image mount tests

@Honny1 Honny1 force-pushed the fix-top-layer-not-found-storage branch 5 times, most recently from 1599dd1 to aac8699 Compare August 30, 2024 08:48
@Honny1
Copy link
Member Author

Honny1 commented Aug 30, 2024

@Luap99 I have fixed the problem.

Luap99
Luap99 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mtrmac PTAL

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
mtrmac
mtrmac reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me; some possible cleanups.

@mheon
Copy link
Member

mheon commented Aug 30, 2024

LGTM once comments from @mtrmac are addressed

@Honny1 Honny1 force-pushed the fix-top-layer-not-found-storage branch from aac8699 to 100cf9c Compare August 30, 2024 13:57
mtrmac
mtrmac reviewed Aug 30, 2024
View reviewed changes
@Honny1
Vendor c/common:8483ef6022b4
c6fe5e5 
This commit vendor pre-release version of `c/common:8483ef6022b4`.
It also adapts the code to the new `c/common/libimage` API, which
fixes an image listing race that was listing false warnings.

fixes: containers#23331

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
@Honny1 Honny1 force-pushed the fix-top-layer-not-found-storage branch from 100cf9c to c6fe5e5 Compare August 30, 2024 14:14
mtrmac
mtrmac reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d49ac10 into containers:main Aug 30, 2024
93 of 94 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 29, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtrmac mtrmac mtrmac left review comments

@Luap99 Luap99 Luap99 approved these changes

Assignees

@mtrmac mtrmac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

race: completion: Top layer ... not found ... storage may be corrupted
4 participants
@Honny1 @Luap99 @mheon @mtrmac