-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Vendor in latest containers/(storage,common, image, buildah) #18106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Changes since 2023-01-01: - skip mount-cache-selinux-long-name test under remote, with a FIXME requesting that someone see if it can be made to work. - skip six tests that fail under rootless-remote - add new --build-arg-file option: - update man page Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
If this passes, lets get it merged, and then we can see about fixing @edsantiago other broken tests.
|
Sure I will look into those, looks like we need to start downloading tar directly at the server end, I wonder why it was like this in the first way ( but I'll inspect it ) @rhatdan Meanwhile one of the failing system test diff --git a/test/system/070-build.bats b/test/system/070-build.bats
index 1d26cd445..fa318a3e6 100644
--- a/test/system/070-build.bats
+++ b/test/system/070-build.bats
@@ -734,7 +734,7 @@ STEP 1/2: FROM $IMAGE
STEP 2/2: RUN echo x${random2}y
x${random2}y${remote_extra}
COMMIT build_test${remote_extra}
---> [0-9a-f]\{11\}
+--> [0-9a-f]\{12\}
Successfully tagged localhost/build_test:latest
[0-9a-f]\{64\}
a${random3}z" Which was recently changed in buildah here: containers/buildah#4660 cc @edsantiago for info just in case you see more of this short id mismatch ( the length is changed from |
@flouthoc take over this PR to finish it up. I don't have time to work on it. |
Okay taking this over. |
Closing this since I have created a clone here: #18130 |
Does this PR introduce a user-facing change?