Skip to content

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 8, 2023

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2023
@rhatdan rhatdan added the bloat_approved Approve a PR in which binary file size grows by over 50k label Apr 8, 2023
rhatdan and others added 2 commits April 8, 2023 17:51
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Changes since 2023-01-01:
 - skip mount-cache-selinux-long-name test under remote, with
   a FIXME requesting that someone see if it can be made to work.

 - skip six tests that fail under rootless-remote

 - add new --build-arg-file option:
 - update man page

Signed-off-by: Ed Santiago <santiago@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan changed the title Vendor in latest containers/(storage,common, image) Vendor in latest containers/(storage,common, image, buildah) Apr 9, 2023
@rhatdan
Copy link
Member Author

rhatdan commented Apr 9, 2023

If this passes, lets get it merged, and then we can see about fixing @edsantiago other broken tests.
@flouthoc can you look into the following:

skip_if_remote "FIXME: can this test be made to work under podman-remote?" \
               "bud-with-mount-cache-like-buildkit-verify-default-selinux-option"

skip_if_rootless_remote "FIXME: #17788 tar + namespaces over http" \
                        "bud-http-context-with-Dockerfile" \
                        "bud-http-context-dir-with-Dockerfile" \
                        "bud-http-context-with-Containerfile"

skip_if_rootless_remote "FIXME: not sure if 17788 or some other bug" \
                        "bud-github-context" \
                        "bud with Dockerfile from stdin tar" \
                        "build-with-network-test"

@flouthoc
Copy link
Collaborator

Sure I will look into those, looks like we need to start downloading tar directly at the server end, I wonder why it was like this in the first way ( but I'll inspect it )

@rhatdan Meanwhile one of the failing system test podman build - does not gobble stdin that does not belong to it should be fixed by following diff

diff --git a/test/system/070-build.bats b/test/system/070-build.bats
index 1d26cd445..fa318a3e6 100644
--- a/test/system/070-build.bats
+++ b/test/system/070-build.bats
@@ -734,7 +734,7 @@ STEP 1/2: FROM $IMAGE
 STEP 2/2: RUN echo x${random2}y
 x${random2}y${remote_extra}
 COMMIT build_test${remote_extra}
---> [0-9a-f]\{11\}
+--> [0-9a-f]\{12\}
 Successfully tagged localhost/build_test:latest
 [0-9a-f]\{64\}
 a${random3}z"

Which was recently changed in buildah here: containers/buildah#4660

cc @edsantiago for info just in case you see more of this short id mismatch ( the length is changed from 11 to 12 )

@rhatdan
Copy link
Member Author

rhatdan commented Apr 10, 2023

@flouthoc take over this PR to finish it up. I don't have time to work on it.

@flouthoc
Copy link
Collaborator

Okay taking this over.

@flouthoc
Copy link
Collaborator

Closing this since I have created a clone here: #18130

@flouthoc flouthoc closed this Apr 10, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants