Skip to content

WIP: [DO NOT MERGE] pick up storage#1560 #18089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: [DO NOT MERGE] pick up storage#1560 #18089

wants to merge 1 commit into from

Conversation

nalind
Copy link
Member

@nalind nalind commented Apr 6, 2023

Does this PR introduce a user-facing change?

Quite the opposite: if it works, additional image stores will act slightly less weird.

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nalind
Once this PR has been reviewed and has the lgtm label, please assign luap99 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind nalind force-pushed the test-storage-1560 branch from b48f630 to 62c06eb Compare April 6, 2023 21:03
@nalind nalind mentioned this pull request Apr 6, 2023
Merged
@nalind nalind force-pushed the test-storage-1560 branch 2 times, most recently from d905d6a to 3f4e80e Compare April 6, 2023 22:35
@vrothberg
Copy link
Member

All green.

I restarted the flaked machine job.

@nalind
Pick up storage#1560
08e97f1 
[NO NEW TESTS NEEDED]

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind nalind force-pushed the test-storage-1560 branch from 3f4e80e to 08e97f1 Compare April 7, 2023 13:45
@nalind
Copy link
Member Author

nalind commented Apr 7, 2023

Rebased, in part because #18090 has been merged, in part hoping that a reset will help CI launch that failing job.

@mheon
Copy link
Member

mheon commented Apr 7, 2023

I've seen the machine error on other PRs, so I doubt it's specific to these changes. Restarted anyways.

@TomSweeneyRedHat
Copy link
Member

And all happy green test buttons here. Do we start dancing the vendor dance?

@nalind nalind closed this Apr 10, 2023
@nalind nalind deleted the test-storage-1560 branch April 10, 2023 12:32
@nalind
Copy link
Member Author

nalind commented Apr 10, 2023

Looks like #18130 is doing that; closing this one.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nalind @vrothberg @mheon @TomSweeneyRedHat