Update podman to use atomic container and machine config updates #18035
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PTAL @containers/podman-maintainers |
c70870d to
611ad9e
Compare
|
Updated impl to use the same routine I am posting a PR for in containers/common Once that change merges this code can be updated to share it instead of keeping a local func. |
There was a problem hiding this comment.
Could we instead use https://github.com/containers/storage/blob/main/pkg/ioutils/fswriters.go#L33?
If there's something missing for Windows, we should probably update the package there.
I am asking since there seem to be more code paths where we need to write atomically on Windows.
|
/hold |
|
/remove-hold |
|
Looks like the updates to common and storage pull in 512K . Not sure if this is expected, adding bloat approved tag for now since this is unrelated to my changes and seeing if we get a test pass. |
|
CHanges LGTM |
|
I suspect this regression is from something else in either common or storage. When I am back at the keyboard will try and find the source |
5c24169 to
baf1571
Compare
|
Got a clean pass, but updated common to v0.52.0 since that was released and rerunning but no real difference so should be clean baring any flakes |
|
PTAL @containers/podman-maintainers I noticed there is a couple other PRs for the vendoring that this PR dups, if those end up merging first, I can rebase this one. |
|
Let's wait for #18130 to merge, and then rebase on top of that, if that's okay! Other than that, LGTM, TY! |
|
sure sgtm! |
Windows: Flush machine config writes before renaming Windows: Previously this code was changed to improve atomicity by changing the persitence approach to a two-step process (write + rename). However, the first-step write operation was not fully flushed, leading to the possibility of incomplete writes. [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
Fixes #18011
Updates container configuration and machine configuration state saving to be atomic on Linux, Mac, and Windows.