Fix git-validation on PRs behind main
#2342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2c354c0 fails … |
80cb99f to
9c3be11
Compare
mtrmac
commented
Jun 2, 2025
| @@ -1,16 +1,19 @@ | |||
| module github.com/containers/storage/tests/tools | |||
|
|
|||
| go 1.18 | |||
| go 1.23.0 | |||
|
|
|||
| require ( | |||
| github.com/cpuguy83/go-md2man v1.0.10 | |||
There was a problem hiding this comment.
BTW this version is also 6 years old, but I’ll leave that update to someone who wants to investigate differences in the generated nroff syntax.
|
(As a demo, this PR is intentionally behind |
git-validation on PRs behind maingit-validation on PRs behind main
|
… marked as “ready for review” now. |
|
@flouthoc PTAL |
CIRRUS_BASE_SHA is a valid commit, but it might not be
a parent of the current PR, so it might not be available,
making a ${CIRRUS_BASE_SHA}..$something git commit range expressions
fail.
Compare cirruslabs/cirrus-ci-docs#1279 .
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... from a 6-year-old version Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, Luap99, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-validationfails on this repo unless the PR is rebased because theCIRRUS_BASE_SHAcommit is not fetched into the build environment by default, so fetch it.Also update
git-validationfrom a 6-year-old version, although that’s probably not strictly necessary.