Skip to content

overlay: drop unused fsMagic from support checks #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Jun 2, 2025

The fsMagic parameter was not used within the
checkAndRecordOverlaySupport and supportsOverlay functions.

Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 2, 2025
@giuseppe giuseppe changed the title overlay: Rm unused fsMagic from support checks overlay: drop unused fsMagic from support checks Jun 2, 2025
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; rebasing might help with the lint failure.

The `fsMagic` parameter was not used within the
`checkAndRecordOverlaySupport` and `supportsOverlay` functions.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the assume-overlay-is-supported-if-fs-unknown branch from 980a1ca to 42e906b Compare June 9, 2025 07:02
@giuseppe
Copy link
Member Author

giuseppe commented Jun 9, 2025

rebased

@mtrmac
Copy link
Collaborator

mtrmac commented Jun 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 32a123c into containers:main Jun 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants