dirvers/btrfs: remove btrfs_noversion tag #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header should be included since btrfs-progs 3.16.1, it is over 10 years old now so I think we can just drop the tag and assume it is always there. This allows us to simplify the buildtag script as well. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Apr 16, 2025
It was removed in containers/storage#2308 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Apr 16, 2025
c/storage no longer uses this tag after containers/storage#2308 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
FWIW this can be also removed in users after the current vendor dance. |
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Apr 16, 2025
c/storage no longer uses this tag after containers/storage#2308 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Apr 30, 2025
c/storage no longer uses this tag after containers/storage#2308. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
May 14, 2025
It was removed in containers/storage#2308 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
May 14, 2025
It was removed in containers/storage#2308 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
May 14, 2025
It was removed in containers/storage#2308 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
rahilarious
added a commit
to rahilarious/podman-tui
that referenced
this pull request
Jul 7, 2025
Since c/storage 1.58.0, this tag is no longer effective containers/storage#2308 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
rahilarious
added a commit
to rahilarious/podman-tui
that referenced
this pull request
Jul 7, 2025
1. btrfs_noversion Since c/storage 1.58.0, this tag is no longer effective containers/storage#2308 2. exclude_graphdriver_devicemapper Not effective since c/storage 1.54 containers/storage#1622 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
rahilarious
added a commit
to rahilarious/podman-tui
that referenced
this pull request
Jul 7, 2025
1. btrfs_noversion Since c/storage 1.58.0, this tag is no longer effective containers/storage#2308 2. exclude_graphdriver_devicemapper Not effective since c/storage 1.54 containers/storage#1622 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
rahilarious
added a commit
to rahilarious/buildah
that referenced
this pull request
Jul 7, 2025
containers/storage#2308 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
rahilarious
added a commit
to rahilarious/gentoo
that referenced
this pull request
Jul 7, 2025
btrfs_noversion buildtag is no longer effective containers/storage#2308 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
rahilarious
added a commit
to rahilarious/gentoo
that referenced
this pull request
Jul 7, 2025
Remove BUILDTAGS btrfs_noversion & exclude_graphdriver_devicemapper as no longer effective containers/storage#2308 containers/storage#1622 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
rahilarious
added a commit
to rahilarious/gentoo
that referenced
this pull request
Jul 7, 2025
Remove BUILDTAGS btrfs_noversion & exclude_graphdriver_devicemapper as no longer effective containers/storage#2308 containers/storage#1622 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 8, 2025
btrfs_noversion buildtag is no longer effective containers/storage#2308 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks> From: #42919 Signed-off-by: Zac Medico <zmedico@gentoo.org>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 8, 2025
Remove BUILDTAGS btrfs_noversion & exclude_graphdriver_devicemapper as no longer effective containers/storage#2308 containers/storage#1622 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks> From: #42919 Signed-off-by: Zac Medico <zmedico@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header should be included since btrfs-progs 3.16.1, it is over 10 years old now so I think we can just drop the tag and assume it is always there. This allows us to simplify the buildtag script as well.