ci: add nolintlint and unconvert linters, fix found issues #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move common code to atime() helper. 2. Use Atim.Unix to simplify conversion and avoid explicit typecasts. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Mostly to avoid explicit typecasts. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Those are the cases where the value being converted is already of that type (checked to be that way for all os/arch combinations). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
For struct Stat_t in syscall pkg: - Ino is always uint64; - Dev/Rdev can be uint64, uint32, or int32; - Nlink might be uint64, uint32, or uint16. Fix the code accordingly, adding or removing typecasts where needed, and annotating those with //nolint:unconvert to calm down the unconvert linter. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
> pkg/reexec/reexec.go:52:27: directive `//nolint: unused` is unused for linter "unused" (nolintlint)
> func naiveSelf() string { //nolint: unused
> ^
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
> pkg/unshare/unshare_linux.go:471:64: directive `// nolint: revive,goprintffuncname` should be written without leading space as `//nolint: revive,goprintffuncname` (nolintlint)
> func bailOnError(err error, format string, a ...interface{}) { // nolint: revive,goprintffuncname
> ^
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, kolyshkin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit. See individual commits for details.