fix minor review comment about the driver mutex and a minor lint issue #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for the extra pointer indirection. With this Driver can no longer be copied but that was never supported and now lint should even catch a copy and warn as copying a Mutex is not allowed. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
CI doesn't seem to cover the libsubid build tag. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This should ensure we run lint with the libsubid build tag. Now this is not perfect either, as we do not cover the !libsubid but that is only one single simple file. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Looks like it still doesn't run in CI with the tag... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The library argument must be after the sources. Not sure why this works on fedora. Taken from a the podman fix[1]. [1] containers/podman@8ff54cb Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
Ok, now it worked. The
|
|
cc @mtrmac (for the mutex change based off your comment) |
This was referenced Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
driver/overlay: inline the mutex in driver
There is no need for the extra pointer indirection. With this Driver can
no longer be copied but that was never supported and now lint should
even catch a copy and warn as copying a Mutex is not allowed.
pkg/idtools: fix lint gofumpt error
CI doesn't seem to cover the libsubid build tag.
CI: add libsubid to lint task
This should ensure we run lint with the libsubid build tag.
Now this is not perfect either, as we do not cover the !libsubid but
that is only one single simple file.