Skip to content

idmap: fix first argument to open_tree #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

giuseppe
Copy link
Member

0 is a valid file descriptor, to ignore the argument we need to use AT_FDCWD.

0 is a valid file descriptor, to ignore the argument we need to use
AT_FDCWD.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me but how was this not caught before? Presumably you saw a failure somewhere else (podman CI? just guessing?) - I personally like to have at least a basic cookie like that in commit messages.

Copy link
Contributor

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member Author

no, I've seen it only by looking at the code while working on something else: https://github.com/giuseppe/storage/tree/no-leak-idmapped-lower-layers

That is just a WIP for now, it depends on a new kernel patch that will be in the 6.15 version

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7595f18 into containers:main Mar 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants