Update old dependencies #2282
Merged
Update old dependencies #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
commented
Mar 14, 2025
| golang.org/x/sync v0.11.0 | ||
| golang.org/x/sys v0.30.0 | ||
| gotest.tools v2.2.0+incompatible | ||
| gotest.tools/v3 v3.5.2 |
There was a problem hiding this comment.
This clearly invites a question whether the project should be depending on both github.com/stretchr/testify and gotest.tools/v3.
Solving that is not a goal of this PR (which focuses on old/unmaintained/non-updated dependencies).
|
needs a rebase |
|
Rebased. |
|
@giuseppe PTANL. |
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We have been using a version over 6 years old. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…8cf8 Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bots generally update direct dependencies, and dependencies with known vulnerabilities.
For indirect dependencies which are over a year old, and either have a newer tagged release or haven’t been using a tagged release anyway, update to the latest version.
(This does nothing about dependencies with no upstream activity, or officially deprecated or even archived.)