Add link to c/common contributor's guide #2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
7ea4e02 to
0e9d1d8
Compare
|
A couple of tweaks, otherwise LGTM. |
Fixes: https://issues.redhat.com/browse/RUN-2321 Signed-off-by: Jan Rodák <hony.com@seznam.cz>
0e9d1d8 to
f5c720a
Compare
|
LGTM |
|
/approve |
|
/lgtm |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, rhatdan, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a link to the updated c/common contributor's guide to reduce the costs of updating the contribution guide and removes duplicate information.
Question for reviewer: I don't know if the communication part is still valid? If it's deprecated and I can remove it.
Fixes: https://issues.redhat.com/browse/RUN-2321