subid: drop support for old version #2277
Conversation
There was a problem hiding this comment.
This breaks build support for RHEL 9
[root@vm-10-0-187-181 ~]# ls /usr/lib64/libsubid.so.3
/usr/lib64/libsubid.so.3
[root@vm-10-0-187-181 ~]# ls /usr/lib64/libsubid.so.4
ls: cannot access '/usr/lib64/libsubid.so.4': No such file or directory
[root@vm-10-0-187-181 ~]# cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="9.6 (Plow)"
...
I don't think we can drop support for RHEL 9 at this point?
ff78848 to
12041e1
Compare
use the subuid init function to initialize the library instead of using the unexported variables. Closes: containers#2260 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
12041e1 to
f6824dd
Compare
shurg, I assumed we moved on from that old version. Thanks for checking it. I've fixed the patch |
There was a problem hiding this comment.
Now that I look at it I remembered https://issues.redhat.com/browse/RHEL-21366.
I think this would fix that as we correctly use the init function now?
|
@kolyshkin PTAL |
|
@mtrmac PTAL |
|
@flouthoc PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the new ABI has been around for more than 3 years now (shadow-utils v4.11).
Closes: #2260