Skip to content

feat: add Timestamp to TarOptions #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aeijdenberg
Copy link
Contributor

Allows overriding of timestamps for entries within an archive.

TarOptions already includes a number of other overrides, it seemed like a good place to add this one as well.

(am keen to look at getting buildah to have the ability to emit identical tarballs for oci-archive, and this is the first step)

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please squash the two commits

This allows overriding of timestamps for entries within an archive.

Signed-off-by: Adam Eijdenberg <adam@continusec.com>
@aeijdenberg aeijdenberg force-pushed the setfixedtimestampforarchiveentries branch from 78809a0 to f51eeb9 Compare February 20, 2025 07:18
@aeijdenberg
Copy link
Contributor Author

Squashed and rebased.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@containers/storage-maintainers PTAL

Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aeijdenberg, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Feb 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3a013da into containers:main Feb 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants