Skip to content

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 3, 2025

@saschagrunert saschagrunert force-pushed the hashicorp branch 2 times, most recently from f886425 to 118b8e3 Compare February 3, 2025 08:49
@saschagrunert saschagrunert changed the title WIP: Remove hashicorp dependencies Remove hashicorp dependencies Feb 3, 2025
@saschagrunert
Copy link
Member Author

@containers/storage-maintainers PTAL

@nalind
Copy link
Member

nalind commented Feb 3, 2025

errors.Join() was introduced in Go 1.20. errors.Is() and errors.As() can correctly traverse a set of joined errors.
LGTM

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!

@mtrmac
Copy link
Collaborator

mtrmac commented Feb 3, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a78d068 into containers:main Feb 3, 2025
20 checks passed
@saschagrunert saschagrunert deleted the hashicorp branch February 3, 2025 18:30
@mheon
Copy link
Member

mheon commented Feb 5, 2025

@saschagrunert But these are in https://github.com/cncf/foundation/blob/main/license-exceptions/CNCF-licensing-exceptions.csv - they should be listed as exceptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants