overlay: additional layer: check layer existence before using #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
reviewed
Sep 24, 2024
drivers/overlay/overlay.go
Outdated
| if ld, err := os.Readlink(diffPath); err == nil { | ||
| // diff is the link to Additional Layer Store | ||
| if !path.IsAbs(ld) { | ||
| return "", fmt.Errorf("linkpath must be absolute (got: %q)", ld) | ||
| } | ||
| if checkExistence { | ||
| if _, err := os.Stat(ld); err != nil { |
There was a problem hiding this comment.
could you please use fileutils.Exists()?
There was a problem hiding this comment.
Thanks for the review. Fixed to use fileutils.Exists.
Currently *Driver.get doesn't check existence of additional layers. This result in an unclear error. This commit fixes that function to check the existence of additional layers before using and return a clear error. Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
e646e4e to
defaae6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, ktock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently *Driver.get doesn't check existence of additional layers. This result in an unclear error, like
mkdir /var/lib/containers/storage/overlay/a4fe7aa552629d15640e70d18b00359e6b58c413ba8aa6c57ec5a63a5742584d/diff: file exists.This commit fixes that function to check the existence of additional layers before using and return a clear error.