Skip to content

Conversation

cgwalters
Copy link
Contributor

xref #2065 (comment)

This does the same for the man page that I did for the default storage.conf previously; instead of trying to squash all the pull_options into a single option that we document "ad-hoc", make it its own table just like the other sections.

  • Add notes about "string bools" around relevant values.
  • Avoid redundantly specifying the default; the default is the first thing we show after the =.

Synchronize the text between the man page and the default storage.conf.

xref containers#2065 (comment)

This does the same for the man page that I did for the default
storage.conf previously; instead of trying to squash all the
`pull_options` into a single option that we document "ad-hoc", make
it its own table just like the other sections.

- Add notes about "string bools" around relevant values.
- Avoid redundantly specifying the default; the default is the first
  thing we show after the `=`.

Synchronize the text between the man page and the default
`storage.conf`.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@cgwalters
Copy link
Contributor Author

(also needs approve)

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 28, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 20daaa6 into containers:main Aug 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants