Create Store.List method for listing layers, images, containers
#2061
Conversation
f790e26 to
241088a
Compare
store.go
Outdated
| @@ -84,6 +84,20 @@ type ApplyStagedLayerOptions struct { | |||
| DiffOptions *drivers.ApplyDiffWithDifferOpts // Mandatory | |||
| } | |||
|
|
|||
| // Options of List methode | |||
There was a problem hiding this comment.
This is at the top level of the package, there can be several things with a List method.
StoreListOptions? Or maybe name the method something unique like MultiList and then make this a MultiListOptions?
Similarly for the result type.
(Also, in both comments, a typo.)
Store.List methode for listing layers, images, containersStore.List method for listing layers, images, containers
f6bcf4e to
9247029
Compare
9247029 to
613df15
Compare
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
613df15 to
b175ede
Compare
There was a problem hiding this comment.
LGTM.
I suppose we should wait with merging this until we know that this is sufficient to fix the user; that’s containers/common#2125 I think.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR implements a method for listing layers, images and containers. Method
Store.Listrequires parameter typeListOptionsthat specifies the content of the return value. The return value is the structureListResultthat contains slices of layers, images or containers according to given options. TheListmethod uses a locking mechanism so that the result is the current snapshot of the items listed.Fixes: