Skip to content

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Aug 6, 2024

simplify the error handling for openNextAvailableLoopback and avoid named return values

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
simplify the error handling for openNextAvailableLoopback and avoid
named return values

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the fix-loopback-error branch from 3b979e6 to d31e825 Compare August 6, 2024 10:37
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2024

@mtrmac @nalind @saschagrunert PTAL

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have learned to strongly distrust named return values and I like this.

Absolutely non-blocking: consider turning the top-level loop into a canonical for remaining := …; remaining > 0; remaining-- instead of a notionally-infinite one.

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,rhatdan,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Aug 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1c2a44f into containers:main Aug 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants