Extend PutLayer to optimize reusing data from existing layers #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the caller provides neither OriginalDigest nor UncompressedDigest, only digest the layer once. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This allows us to correctly set (CompresedDigest, CompressedSize) when copying data from another layer; in that case we don't have the compressed data, so computing the size from compressedCounter sets an incorrect value. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
37 tasks
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayersByTOCDigest), only digest uncompressed input once, not twiceCompressedSizevalue to matchCompressedDigest, so that we don't create layers with incorrect metadata.Motivated by containers/image#2288 .
Cc: @giuseppe (fairly low priority)