Skip to content

chunked layersCache seems to never be actually reused #2023

@mtrmac

Description

@mtrmac

A side discovery I can’t delve into now:

cache := &layersCache{
defines a new local variable, it does not change the value of the global singleton:
cache *layersCache

AFAICS that means every cache user ( = every chunked differ = every layer extraction) builds the cache from scratch. The fix is trivial in itself, but it would expose currently-impossible concurrency, so it might need specific testing.

Cc: @giuseppe

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions