Skip to content

Fix d.getStagingDir("") #2092

@mtrmac

Description

@mtrmac

Since #1784 ,

stagingDir := d.getStagingDir(id)
is calling getStagingDir(""), i.e. dir2 with a layer ID "".

Just from reading the code, that happens to work as expected because it is not using the primary return value of dir2, but that’s extremely non-obvious and very likely to be broken during future maintenance. To the extent the cod is only looking for the “homeDir”, I think that should be modeled explicitly and not use the id value at all. Alternatively, if the id value mattered, then this needs to actually be implemented.

Cc: @giuseppe

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions