-
Notifications
You must be signed in to change notification settings - Fork 262
Closed
Labels
Description
Since #1784 ,
storage/drivers/overlay/overlay.go
Line 2188 in 10981ab
stagingDir := d.getStagingDir(id) |
getStagingDir("")
, i.e. dir2
with a layer ID ""
.
Just from reading the code, that happens to work as expected because it is not using the primary return value of dir2
, but that’s extremely non-obvious and very likely to be broken during future maintenance. To the extent the cod is only looking for the “homeDir”, I think that should be modeled explicitly and not use the id
value at all. Alternatively, if the id
value mattered, then this needs to actually be implemented.
Cc: @giuseppe