Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containers/storage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.51.1
Choose a base ref
...
head repository: containers/storage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.51.2
Choose a head ref
  • 8 commits
  • 5 files changed
  • 3 contributors

Commits on Jul 11, 2024

  1. Merge pull request #1990 from TomSweeneyRedHat/dev/tsweeney/acel244-1.51

    [release-1.51] Backport ignore chown errors in additionalimagestore
    TomSweeneyRedHat authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d270930 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. userns: fix off-by-one userns max size detection

    fix the detection for the maximum userns size from an image.
    
    If the maximum ID used in an image is X, we need to use a user
    namespace with size X+1 to include UID=X.
    
    Closes: #2104
    
    Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
    giuseppe authored and mheon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bfb1a6d View commit details
    Browse the repository at this point in the history
  2. users: fix path for /etc/group in the container

    Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
    giuseppe authored and mheon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f4f1e4f View commit details
    Browse the repository at this point in the history
  3. userns: skip "nogroup"

    the alpine image defines a "nogroup":
    
    $ podman run --rm alpine grep nogroup /etc/group
    nogroup:x:65533:
    
    ignore it as we are already doing for the "nobody" user.
    
    Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
    giuseppe authored and mheon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b4407e3 View commit details
    Browse the repository at this point in the history
  4. Use securejoin.SecureJoin when forming userns paths

    We need to read /etc/passwd and /etc/group in the container to
    get an idea of how many UIDs and GIDs we need to allocate for a
    user namespace when `--userns=auto` is specified. We were forming
    paths for these using filepath.Join, which is not safe for paths
    within a container, resulting in this CVE allowing crafted
    symlinks in the container to access paths on the host instead.
    
    Cherry-pick conflict fixed for v1.51 branch, and converted to use
    the old securejoin API (securejoin.SecureJoin and then os.Open)
    as this branch is too old to have the new API.
    
    Addresses CVE-2024-9676
    
    Signed-off-by: Matt Heon <mheon@redhat.com>
    mheon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0dc4fc9 View commit details
    Browse the repository at this point in the history
  5. Use golang:1.19 for lint, instead of latest

    Signed-off-by: Matt Heon <mheon@redhat.com>
    mheon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2ebd9bb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e7a5bf7 View commit details
    Browse the repository at this point in the history
  7. [release-1.51] Bump version to v1.51.2

    As the title says.  Bumping the version to fix CVE-2024-9676 in this
    branch.
    
    Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
    TomSweeneyRedHat committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c7649e8 View commit details
    Browse the repository at this point in the history
Loading