Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containers/storage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.57.0
Choose a base ref
...
head repository: containers/storage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.57.1
Choose a head ref
  • 6 commits
  • 3 files changed
  • 1 contributor

Commits on Jan 30, 2025

  1. Reorganize chunkedDiffer 

    Try to split fields by purpose, and document some of the context.

For consistency, use the same order in the struct literals.

Only reorders existing fields, should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    4738e20 View commit details
    Browse the repository at this point in the history

  2. Remove the canFallback return value 

    Instead, have the callees produce ErrFallbackToOrdinaryLayerDownload
directly.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    03c29fa View commit details
    Browse the repository at this point in the history

  3. Move the canFallback logic from make...Differ into read...Manifest 

    That's a logically better place, it pairs the getBlobAt
calls with the ErrBadRequest types specific to those call sites.

We will, also, add more fallback reasons.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    c2f9a31 View commit details
    Browse the repository at this point in the history

  4. Allow falling back from partial pulls if the metadata is too large 

    ... but not if the fallback would be convert_images, again
creating too large metadata.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    19ce25a View commit details
    Browse the repository at this point in the history

  5. Bump maxTocSize to 150 MB 

    We have seen an image with:
- total size 1.43 GB
- uncompressed zstd:chunked manifest size of 91.7 MB
- uncompressed tar-split size (not constrained by maxTocSize) 310 MB

Without more infrastructure, we are just guessing about what
the system we are running on can support, so, for now, *shrug*, bump
the number.

Eventually we should stream the data from/to disk, making this
much less relevant; that makes building the infrastructure to
estimate available memory unattractive.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    2d3c440 View commit details
    Browse the repository at this point in the history

  6. Release 1.57.1 

    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    d16a375 View commit details
    Browse the repository at this point in the history
Loading