Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containers/storage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.56.0
Choose a base ref
...
head repository: containers/storage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.56.1
Choose a head ref
  • 3 commits
  • 2 files changed
  • 3 contributors

Commits on Dec 9, 2024

  1. store: correctly remove incomplete layers on load.

    In go one should never modify a slice while also iterating over it at
    the same time. This causes weird side effects as the underlying array
    elements are shifted around without the range loop index knowing.
    So if you delete a element the loop will then actually skip the next one
    and theoretically access out of bounds on the last element which does
    not panic but rather return the default zero type, nil here which then
    causes the panic on layer.Flags == nil.
    
    Here is a simple example to show the behavior:
    func main() {
    	slice := []int{1, 2, 3, 4, 5, 6, 7, 8, 9}
    	for _, num := range slice {
    		if num == 5 {
    			slice = slices.DeleteFunc(slice, func(n int) bool {
    				return n == 5
    			})
    		}
    		fmt.Println(num)
    	}
    }
    
    The loop will not print 6, but then as last number it prints 0 (the
    default zero type for an int).
    
    Fixes #2184
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    (cherry picked from commit 99b0d2d)
    Luap99 committed Dec 9, 2024
    Configuration menu
    Copy the full SHA
    359b5d5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2193 from Luap99/backport-1.56

    [release-1.56] store: correctly remove incomplete layers on load.
    openshift-merge-bot[bot] authored Dec 9, 2024
    Configuration menu
    Copy the full SHA
    9e9a1f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2025

  1. [release-1.56] Bump to c/storage v1.56.1

    In preparation for Podman v5.3.2, bump c/storage to v1.56.1.
    
    Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
    TomSweeneyRedHat committed Jan 14, 2025
    Configuration menu
    Copy the full SHA
    a8b2ebe View commit details
    Browse the repository at this point in the history
Loading