Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containers/ocicrypt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.9
Choose a base ref
...
head repository: containers/ocicrypt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.0
Choose a head ref
  • 11 commits
  • 11 files changed
  • 4 contributors

Commits on Nov 13, 2023

  1. build(deps): bump github.com/go-jose/go-jose/v3 from v3.0.0 to v3.0.1

    To avoid a potential DoS vulnerability in v3.0.0 update to v3.0.1.
    
    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
    stefanberger committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a24b477 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0

    Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
    - [Commits](golang/crypto@v0.14.0...v0.17.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/crypto
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and stefanberger committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    c430e43 View commit details
    Browse the repository at this point in the history
  2. jwe: Support overriding the algorithm when supplying a JWK

    Now, passing a JWK (via EncryptWithJwe / JSONWebKey.MarshalJSON) will
    allow for ECDSA keys and for customizing the algorithm used with a
    particular key.
    
    Previously, the code made it impossible to supply a JWK-encoded ECDSA
    public key in the encryption config, as all keys passed as JSONWebKey-s
    were treated as RSA_OAEP keys, since utils.ParsePublicKey delegates to
    parseJWKPublicKey which returns the JWK itself; and hence the switch in
    the JWE keywrap failed to detect those as an ecdsa public key.
    A simpler patch here would have been to change parseJWKPublicKey to return
    the key contained inside the JWK directly, however, as pointed out by
    stefanberger, this would have broken backwards compatibility of the public
    API. Plus, using the algorithm encoded in the JWK allows us to more easily
    extend the JWE encoder to new algorithms.
    
    Risks: JWK-s containing RSA keys but with .Algorithm not set to "" (the
    default value) or string(jose.RSA_OLAP) will end up erroring or producing
    different encryptions than before. However, such keys would have failed to
    decrypt the contents regardless, so it should be fine to consider this a
    correction rather than breakage of old behavior. (Hyrum's law
    notwithstanding)
    
    Signed-off-by: Bojidar Marinov <bojidar.marinov.bg@gmail.com>
    bojidar-bg authored and stefanberger committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    4b2101a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. build(deps): bump github.com/go-jose/go-jose/v3 from v3.0.1 to v3.0.3

    To avoid a potential DoS vulnerability in v3.0.0 update to v3.0.3.
    
    Resolves: Issue #104
    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
    stefanberger committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ccaf1f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. build(deps): bump github.com/golang/protobuf from v1.5.3 to v1.5.4

    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
    stefanberger committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f840ae2 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. ---

    updated-dependencies:
    - dependency-name: golang.org/x/net
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and stefanberger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    30c2fb6 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. github: Test with go 1.22 and go 1.21

    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
    stefanberger committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c448946 View commit details
    Browse the repository at this point in the history
  2. Refactor conditionless else branches with return statementes (govet)

    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
    stefanberger committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5221197 View commit details
    Browse the repository at this point in the history
  3. github: Use golangci-lint v1.59.1 and adjust config file

    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
    stefanberger committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7d0db72 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Migrate to go-jose/v4

    The main change in go-jose/v4 is the requirement to specify accepted
    "alg" and "enc" parameters. This is to enhance security, like for
    instance "the billion hashes attach" presented at BlackHat 2023.
    
    Note that go-jose/v4 requires go 1.21
    
    References:  go-jose/go-jose#64 (comment)
    Signed-off-by: Reinhard Tartler <siretart@tauware.de>
    siretart authored and stefanberger committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    0703ce7 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. build(deps): Update several dependencies to latest package versions

    Update the following packages:
    - github.com/opencontainers/image-spec: v1.1.0
    - github.com/sirupsen/logrus: v1.9.3
    - github.com/stretchr/testify: v1.9.0
    - golang.org/x/crypto: v0.24.0
    - golang.org/x/term: v0.21.0
    - google.golang.org/grpc: v1.64.0
    
    Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
    stefanberger committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e26515d View commit details
    Browse the repository at this point in the history
Loading