Run CI all on the Fedora images #2890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to simplify, and to allow using recent packages. We were using Debian because previously we were using Ubuntu, and that was because Ubuntu was the native distribution of Travis even before we were running CI in any kind of container; so there seems to have been no specific intent to use a non-Fedora OS, at least originally. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
commented
Jul 4, 2025
| @@ -142,7 +133,6 @@ meta_task: | |||
| # Space-separated list of images used by this repository state | |||
| IMGNAMES: | | |||
| ${FEDORA_CACHE_IMAGE_NAME} | |||
| ${DEBIAN_CACHE_IMAGE_NAME} | |||
There was a problem hiding this comment.
@lsm5 PTAL, to ensure this does not break something I’m unaware of.
There was a problem hiding this comment.
That is fine, you just need to list the image in use here so the auto prune service doesn't not delete them.
There was a problem hiding this comment.
Doesn't look it breaks anything AFAICT.
Luap99
approved these changes
Jul 4, 2025
| @@ -142,7 +133,6 @@ meta_task: | |||
| # Space-separated list of images used by this repository state | |||
| IMGNAMES: | | |||
| ${FEDORA_CACHE_IMAGE_NAME} | |||
| ${DEBIAN_CACHE_IMAGE_NAME} | |||
There was a problem hiding this comment.
That is fine, you just need to list the image in use here so the auto prune service doesn't not delete them.
|
ah no mergebot here . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to simplify, and to allow using recent packages.
We were using Debian because previously we were using Ubuntu, and that was because Ubuntu was the native distribution of Travis even before we were running CI in any kind of container; so there seems to have been no specific intent to use a non-Fedora OS, at least originally.