[5.34] Correctly compute DiffID, and try to set the correct MIME type, for non-gzip input to tarball:
#2807
+39
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the layerType value closer to the code that actually knows the format. Don't allocate/initialize a sha256 state if we don't know we are going to need it. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Correctly compute the DiffID of non-gzip-compressed layers, and if possible, set the layer MIME type correctly. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM |
|
Fixes: https://issues.redhat.com/browse/RHEL-85218 and https://issues.redhat.com/browse/RHEL-85219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2795.
Marked as draft, pending a decision on whether we can include this. Cc: @TomSweeneyRedHat