Add warnings about direct use of ImageSource #2742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switching to draft, per containers/buildah#6014 (review) :
|
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Updated, PTAL. |
mtrmac
commented
Apr 2, 2025
| @@ -15,6 +15,9 @@ type UnparsedImage = image.UnparsedImage | |||
| // UnparsedInstance returns a types.UnparsedImage implementation for (source, instanceDigest). | |||
| // If instanceDigest is not nil, it contains a digest of the specific manifest instance to retrieve (when the primary manifest is a manifest list). | |||
| // | |||
| // This implementation of [types.UnparsedImage] ensures that [types.UnparsedImage.Manifest] validates the image | |||
| // against instanceDigest if set, or, if not, a digest implied by src.Reference, if any. | |||
There was a problem hiding this comment.
The “implied by” is intentionally a bit vague, there is #1049 and I’m not yet sure how to handle that. For now, we must provide this feature for at least registry references, and in that case the meaning is clear enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc: @Luap99 , I’ve noticed some problematic users recently. I’ll also audit our codebases.