Skip to content

Fix omitempty for PKI struct #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Fix omitempty for PKI struct #2746

merged 1 commit into from
Mar 3, 2025

Conversation

QiWang19
Copy link
Member

Add omitempty annotations to PKI APIs

@QiWang19
Fix omitempty for PKI struct
4b6d94e 
Add omitempty annotations to PKI APIs

Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19
Copy link
Member Author

@mtrmac Could you review? Sorry I just found out I wrote this bug.

@rhatdan
Copy link
Member

rhatdan commented Mar 1, 2025

LGTM

mtrmac
mtrmac approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is a ~cleanup, it does not break anything serious to warrant backporting, does it?

@mtrmac mtrmac merged commit c3293ec into containers:main Mar 3, 2025
10 checks passed
@QiWang19
Copy link
Member Author

QiWang19 commented Mar 3, 2025

@mtrmac Yes, it does not break anything serious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QiWang19 @rhatdan @mtrmac